<html>
<head><meta charset="utf-8"><title>bors priority for high priority bug fixes · t-compiler/wg-prioritization · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/index.html">t-compiler/wg-prioritization</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html">bors priority for high priority bug fixes</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="200149147"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149147" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149147">(Jun 08 2020 at 20:04)</a>:</h4>
<p><span class="user-group-mention" data-user-group-id="2403">@WG-prioritization</span> I've mentioned to <span class="user-mention" data-user-id="116083">@pnkfelix</span> and <span class="user-mention" data-user-id="116009">@nikomatsakis</span> that merging PRs that close high priority issues should be <code>@bors p=1</code> or something like that to get them in faster</p>



<a name="200149214"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149214" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149214">(Jun 08 2020 at 20:05)</a>:</h4>
<p>Generally, depends on the size of the pr, smaller ones gets rolled up</p>



<a name="200149238"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149238" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149238">(Jun 08 2020 at 20:05)</a>:</h4>
<p>that gives more time to test these changes and less conflicts for those</p>



<a name="200149249"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149249" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149249">(Jun 08 2020 at 20:05)</a>:</h4>
<p>if you feel a pr is large enough, either mark it with priority or rollup=never</p>



<a name="200149265"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149265" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149265">(Jun 08 2020 at 20:05)</a>:</h4>
<p>i prioritise those every evening</p>



<a name="200149296"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149296" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149296">(Jun 08 2020 at 20:05)</a>:</h4>
<p>yeah but this is regardless <code>rollup</code></p>



<a name="200149311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149311">(Jun 08 2020 at 20:06)</a>:</h4>
<p>(deleted)</p>



<a name="200149390"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149390" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149390">(Jun 08 2020 at 20:06)</a>:</h4>
<p>for instance</p>



<a name="200149393"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149393" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149393">(Jun 08 2020 at 20:06)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/71896">#71896</a></p>



<a name="200149396"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149396" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149396">(Jun 08 2020 at 20:06)</a>:</h4>
<p>yeah i agree.. just mark it as high priority</p>



<a name="200149439"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149439" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149439">(Jun 08 2020 at 20:07)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="200149456"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149456" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149456">(Jun 08 2020 at 20:07)</a>:</h4>
<p>but we were also talking about adding some sort of policy for this</p>



<a name="200149464"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149464" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149464">(Jun 08 2020 at 20:07)</a>:</h4>
<p>well "policy"</p>



<a name="200149484"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149484" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149484">(Jun 08 2020 at 20:07)</a>:</h4>
<p>or if it is small enough, mark it as rollup=always, and it will be merged sooner or later</p>



<a name="200149488"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149488" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149488">(Jun 08 2020 at 20:07)</a>:</h4>
<p>I meant, we can add a page to forge that mentions this and have that as some sort of policy</p>



<a name="200149494"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149494" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149494">(Jun 08 2020 at 20:07)</a>:</h4>
<p>ye i agree.</p>



<a name="200149583"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149583" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149583">(Jun 08 2020 at 20:08)</a>:</h4>
<p>though some members of this wg don't have bors permission</p>



<a name="200149605"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149605" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149605">(Jun 08 2020 at 20:08)</a>:</h4>
<p>yeah, but in the kind of cases I'm talking about, PRs that fixes <code>P-critical</code> issues in general I wouldn't rollup those</p>



<a name="200149657"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149657" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149657">(Jun 08 2020 at 20:09)</a>:</h4>
<p>true. but problem is the p-label is on the issue and not the pr, so i will have to check each issue</p>



<a name="200149676"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149676" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149676">(Jun 08 2020 at 20:09)</a>:</h4>
<p>I meant, I understand why things are rolled up but maybe another kind of policy should be to never rollup PRs for <code>P-critical</code> things</p>



<a name="200149859"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149859" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149859">(Jun 08 2020 at 20:10)</a>:</h4>
<p>yeah, unsure, but it could totally be a suggestion for the reviewer</p>



<a name="200149903"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149903" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149903">(Jun 08 2020 at 20:10)</a>:</h4>
<p>if you're reviewing a PR that fixes a P-critical just do <code>@bors r+ rollup=never p=1</code></p>



<a name="200149906"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200149906" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200149906">(Jun 08 2020 at 20:11)</a>:</h4>
<p>ye better done by the reviewer tbh</p>



<a name="200151590"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200151590" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200151590">(Jun 08 2020 at 20:25)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust-forge/issues/373">forge#373</a></p>



<a name="200152021"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200152021" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200152021">(Jun 08 2020 at 20:29)</a>:</h4>
<p><span class="user-mention silent" data-user-id="120823">DPC</span> <a href="#narrow/stream/227806-t-compiler.2Fwg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes/near/200149657">said</a>:</p>
<blockquote>
<p>true. but problem is the p-label is on the issue and not the pr, so i will have to check each issue</p>
</blockquote>
<p>we could put priority labels on <del>issues</del> PRs if that would help</p>



<a name="200152102"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200152102" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200152102">(Jun 08 2020 at 20:30)</a>:</h4>
<p>ugh; fixed</p>



<a name="200153736"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200153736" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200153736">(Jun 08 2020 at 20:44)</a>:</h4>
<p>You can also give bors those metadata commands before approving the PR. So if you're opening a PR you know fixes a critical issue, you just <code>@bors rollup=never p=1</code> before it even gets reviewed.</p>



<a name="200153944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/bors%20priority%20for%20high%20priority%20bug%20fixes/near/200153944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes.html#200153944">(Jun 08 2020 at 20:47)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116083">pnkfelix</span> <a href="#narrow/stream/227806-t-compiler.2Fwg-prioritization/topic/bors.20priority.20for.20high.20priority.20bug.20fixes/near/200152021">said</a>:</p>
<blockquote>
<p>we could put priority labels on <del>issues</del> PRs if that would help</p>
</blockquote>
<p>yes that would be helpful. thanks</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>